Skip to content

cert-checker: Restore audit tags on findings and run summary#8843

Merged
aarongable merged 1 commit into
reland-slogfrom
slog-audit/04-cert-checker-audit-tags
Jul 6, 2026
Merged

cert-checker: Restore audit tags on findings and run summary#8843
aarongable merged 1 commit into
reland-slogfrom
slog-audit/04-cert-checker-audit-tags

Conversation

@beautifulentropy

@beautifulentropy beautifulentropy commented Jul 6, 2026

Copy link
Copy Markdown
Member

Before #8606 a detected bad certificate was logged via AuditErr and the end-of-run report via AuditInfo. The migration downgraded both to plain Error/Info, silently removing them from Audit.

This PR was generated as part of an audit of #8606 using Claude Fable 5.

Before #8606 a detected bad certificate was logged via AuditErr and the
end-of-run report via AuditInfo. The migration downgraded both to plain
Error/Info, silently removing them from the [AUDIT] stream that gets
extra persistence and durability. Restore the original designations.
@beautifulentropy beautifulentropy requested a review from a team as a code owner July 6, 2026 19:03
@beautifulentropy beautifulentropy requested a review from ezekiel July 6, 2026 19:03
@beautifulentropy beautifulentropy changed the title cert-checker: restore audit tags on findings and run summary cert-checker: Restore audit tags on findings and run summary Jul 6, 2026
@ezekiel ezekiel requested review from a team and jsha and removed request for a team July 6, 2026 19:29
@aarongable aarongable changed the base branch from main to reland-slog July 6, 2026 21:18
@aarongable aarongable merged commit c95f39e into reland-slog Jul 6, 2026
18 checks passed
@aarongable aarongable deleted the slog-audit/04-cert-checker-audit-tags branch July 6, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants