admin: Only log fields being changed in dry-run UpdateIncident#8842
Merged
aarongable merged 1 commit intoJul 7, 2026
Merged
Conversation
The dry-run UpdateIncident log recorded zero values (1970 timestamps, enabled=false) for fields the request leaves unset. A real UpdateIncident only applies non-empty fields, so the dry-run record misrepresented what a real run would do. Log only the fields present in the request, so "absent" always means "not changed".
beautifulentropy
changed the title
aarongable
approved these changes
Jul 6, 2026
ezekiel
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dry-run UpdateIncident log recorded zero values (1970 timestamps, enabled=false) for fields the request leaves unset. A real UpdateIncident only applies non-empty fields, so the dry-run record misrepresented what a real run would do. Log only the fields present in the request, so "absent" always means "not changed".
This PR was generated as part of an audit of #8606 using Claude Fable 5.