feat: Float.Model#14079
Open
TwoFX wants to merge 8 commits into
Open
Conversation
This reverts commit ea1f607.
TwoFX
commented
Jun 16, 2026
|
|
||
| /-- | ||
| A floating point format is specified by two pieces of information: the number | ||
| of bits in the mantissa, and the range of the exponent, which is represented by |
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds types
Float.ModelandFloat32.Modelwhich will serve as logical models for theFloatandFloat32types.This PR contains just the implementation; we don't actually set it as the logical model yet. This will happen in a follow-up PR.
Further documentation will follow. For now, just the following information: the logical model will never support all of the operations that the native
Floattype supports. In this PR, we support the following operations:add,sub,mul,div,sqrt,abs,neg,isNaN,isInf,isFinite,le,lt,beq,ofInt,ofNat,ofIntX,ofUIntX,toIntX,toUIntX. Additional operations might follow in the future.Extensive testing infrastructure is in place validating the model implementation against the native one using difficult test cases generated using Berkeley TestFloat and UCBTest.