fix(middleware): set rate limit headers on memory store#2985
Open
leno23 wants to merge 1 commit into
Open
Conversation
Add optional rateLimiterStoreContext interface so stores can set X-RateLimit-Limit, X-RateLimit-Remaining, and Retry-After headers. RateLimiterMemoryStore implements it using golang.org/x/time/rate. Fixes labstack#2961 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Sorry for the wasteful comment, but I definitely welcome this change. I have been wanting this for awhile. Hopefully this can be reviewed by someone soon. |
Contributor
|
@leno23 is it intentionally agains |
vishr
added a commit
that referenced
this pull request
Jun 14, 2026
…#2961) Implements AllowContext on RateLimiterMemoryStore so the default store sets X-RateLimit-Limit, X-RateLimit-Remaining, and (on deny) Retry-After headers out of the box — mirroring the v4 PR #2985 by @leno23 on the v5 line. Allow() is refactored to share an internal allow() with AllowContext; the optional RateLimiterStoreContext interface (added earlier in this PR) routes the middleware to AllowContext when the store implements it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vishr
added a commit
that referenced
this pull request
Jun 14, 2026
…rs (#2961) (#3007) * feat(middleware): optional RateLimiterStoreContext for response headers (#2961) Adds an optional RateLimiterStoreContext interface. When the configured store implements AllowContext(c, identifier), the rate limiter calls it instead of Allow, giving the store access to the request context so it can set response headers such as Retry-After / X-RateLimit-*. Fully backward compatible: stores implementing only Allow are unchanged. This is the optional-interface approach proposed by the maintainer in the issue thread; it does not alter the existing Allow interface or the built-in store. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(middleware): set X-RateLimit-* / Retry-After from built-in store (#2961) Implements AllowContext on RateLimiterMemoryStore so the default store sets X-RateLimit-Limit, X-RateLimit-Remaining, and (on deny) Retry-After headers out of the box — mirroring the v4 PR #2985 by @leno23 on the v5 line. Allow() is refactored to share an internal allow() with AllowContext; the optional RateLimiterStoreContext interface (added earlier in this PR) routes the middleware to AllowContext when the store implements it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2961
Rate limit middleware now sets standard rate limit response headers when using the built-in
RateLimiterMemoryStore:X-RateLimit-Limit— configured burstX-RateLimit-Remaining— tokens remaining after the requestRetry-After— seconds until the next token is available (on 429 only)Implementation follows the maintainer suggestion from the issue: an optional unexported
rateLimiterStoreContextinterface withAllowContext(c echo.Context, identifier string) (bool, error). When the configured store implements it, the middleware calls it instead ofAllow. Custom stores can opt in without breaking the existingRateLimiterStoreAPI.Retry-Afteris computed viarate.Limiter.ReserveN(...).Delay()as suggested in the issue discussion.Test plan
go test ./middleware -run TestRateLimitergo test -race ./middleware -run TestRateLimiterMemoryStoreTestRateLimiterMemoryStore_AllowContext_SetsHeadersverifies headers on allowed and denied requests