Adding rules to CONTRIBUTING.md#4594
Merged
Merged
Conversation
CsatariGergely
commented
Jun 17, 2026
CsatariGergely
commented
Contributor
- Current CODEOWNER.md based rules for pr approvals. This will be changed ot the maintainer and contributor groups based rules once we agreed to apply them to all the repos.
- Rules for stale prs
- Current CODEOWNER.md based rules for pr approvals. This will be changed ot the maintainer and contributor groups based rules once we agreed to apply them to all the repos. - Rules for stale prs Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project contribution guidelines by expanding the Code reviews section in CONTRIBUTING.md, adding explicit expectations around PR approvals and handling of stale PRs.
Changes:
- Reflows and reformats the existing “Code reviews” text and checklist for readability.
- Adds a requirement for PR approvals based on the
CODEOWNERSfile. - Introduces a “Stale PRs” policy describing when inactive PRs may be closed and how they can be resumed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: GitHub Copilot: Claude Haiku 4.5 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
liamfallon
approved these changes
Jun 29, 2026
aravindtga
approved these changes
Jun 29, 2026
tgzsolt
pushed a commit
to nokia/kpt
that referenced
this pull request
Jun 30, 2026
* Adding rules to CONTRIBUTING.md - Current CODEOWNER.md based rules for pr approvals. This will be changed ot the maintainer and contributor groups based rules once we agreed to apply them to all the repos. - Rules for stale prs Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: GitHub Copilot: Claude Haiku 4.5 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
OisinJohnston2005
pushed a commit
to Nordix/kpt
that referenced
this pull request
Jul 3, 2026
* Adding rules to CONTRIBUTING.md - Current CODEOWNER.md based rules for pr approvals. This will be changed ot the maintainer and contributor groups based rules once we agreed to apply them to all the repos. - Rules for stale prs Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: GitHub Copilot: Claude Haiku 4.5 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
efiacor
pushed a commit
that referenced
this pull request
Jul 9, 2026
* Allowed the default prefix to be specified by env variable or cobra flag Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Added image-prefix as a cli option or env variable Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * It works this time Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Moved to a cleaner implementation and made the same logic apply to eval as well as render Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * cleaned her up a bit Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * cleaned up duplicate code and removed redundant code Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Adding rules to CONTRIBUTING.md (#4594) * Adding rules to CONTRIBUTING.md - Current CODEOWNER.md based rules for pr approvals. This will be changed ot the maintainer and contributor groups based rules once we agreed to apply them to all the repos. - Rules for stale prs Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: GitHub Copilot: Claude Haiku 4.5 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Fix basicpipeline-semver e2e expected output for set-labels v0.2.5 (#4605) Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * docs: update Nephio documentation link in FAQ Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * First section of chapter 3 proofreading. Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Chapter 3 proofreading. Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Fixing indentations in chapter 3. Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Corrections done in chapter 3. Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Apply suggestions from code review Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Breaking a long line Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Fixing WordPress wording Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: GitHub Copilot: Claude Haiku 4.5 Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Apply suggestion from @Catalin-Stratulat-Ericsson Co-authored-by: Catalin Stratulat <159934629+Catalin-Stratulat-Ericsson@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * porch docs navbar redirect (#4611) Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * security - fix Git argument injection via untrusted Kptfile ref enables file overwrite (#4604) Signed-off-by: tar <gabor.tar.ext@nokia.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Specifying allowed alert types (#4612) * Specifying allowed alert types Signed-off-by: Dominika Schweier <dominika.schweier@nokia.com> * Specifying allowed alert types Signed-off-by: Dominika Schweier <dominika.schweier@nokia.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Dominika Schweier <dominika.schweier@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Simplify CI workflows: remove legacy GOPATH checkout pattern (#4597) Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Fixed copilot comments Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * mention the environment variable in the help for the --image-prefix flag Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Fixed copilot comments Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Fixed copilot comments Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * Added prefix validation Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * added unit tests and tightened validation requirements Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> --------- Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech> Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com> Signed-off-by: tar <gabor.tar.ext@nokia.com> Signed-off-by: Dominika Schweier <dominika.schweier@nokia.com> Co-authored-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Aravindhan Ayyanathan <aravindhan.a@est.tech> Co-authored-by: dosubot[bot] <131922026+dosubot[bot]@users.noreply.github.com> Co-authored-by: Michael Greaves <michael.greaves@nokia.com> Co-authored-by: Catalin Stratulat <159934629+Catalin-Stratulat-Ericsson@users.noreply.github.com> Co-authored-by: Tar Gábor Zsolt <gabor.tar.ext@nokia.com> Co-authored-by: Schweier Dominika <dominika.schweier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.