Skip to content

docs: fix stale contribution and e2e debug instructions#9154

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
immanuwell:docs/fix-stale-contrib-instructions
Jul 2, 2026
Merged

docs: fix stale contribution and e2e debug instructions#9154
knative-prow[bot] merged 1 commit into
knative:mainfrom
immanuwell:docs/fix-stale-contrib-instructions

Conversation

@immanuwell

@immanuwell immanuwell commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

A couple contributor docs are stale and trip people up a bit.

hack/README.md still points at master and uses git co, which fails on a normal git setup. DEVELOPMENT.md also points to test/rekt/scenarios and mentions TestMyRektScenario, but neither matches this repo.

How to repro

  1. Run git co -b my-backport-branch upstream/release-X.Y
  2. See git: 'co' is not a git command
  3. Run git symbolic-ref refs/remotes/origin/HEAD and see refs/remotes/origin/main
  4. Run test -d test/rekt/scenarios || echo missing
  5. Run rg 'TestPingSourceWithSinkRef|TestMyRektScenario' test/rekt test -S

Fix is pretty small: use main, switch git co to git checkout, and align the e2e-debug.sh example with the real test and path. Tiny cleanup, but saves a weird faceplant

Signed-off-by: immanuwell <pchpr.00@list.ru>
@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2026
@knative-prow

knative-prow Bot commented Jun 12, 2026

Copy link
Copy Markdown

Hi @immanuwell. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the area/test-and-release Test infrastructure, tests or release label Jun 12, 2026
@knative-prow knative-prow Bot requested review from creydr and evankanderson June 12, 2026 12:13
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.05%. Comparing base (69b976f) to head (4e55357).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9154   +/-   ##
=======================================
  Coverage   51.04%   51.05%           
=======================================
  Files         411      411           
  Lines       22132    22132           
=======================================
+ Hits        11298    11300    +2     
+ Misses       9960     9959    -1     
+ Partials      874      873    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr creydr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @immanuwell

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 2, 2026
@knative-prow knative-prow Bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2026
@knative-prow

knative-prow Bot commented Jul 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, immanuwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2026
@knative-prow knative-prow Bot merged commit 5411419 into knative:main Jul 2, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants