Backport Next 15 and React 19 to previous major#9809
Conversation
|
@AlanBreck ah this already raises an interesting point, this will need to be a major release of I am happy to continue, with the assumption that the new major in |
|
Renamed the target branch to |
Sounds great. Thank you for your willingness to work on this! |
|
@dcousens whats missing for this to ship? Very much appreciating @AlanBreck for his efforts and would like to offer my help to get this up and running as it would make our life here easier as well 😅 |
|
@AlanBreck is this ready to come out of draft? Where did you end up |
|
@MauriceArikoglu I have no doubt @AlanBreck would appreciate you pulling down the branch and testing yourself ❤️ |
I misunderstood Where I left off was getting tests to pass. I believe one blocker is that React needs to be bumped in the
Definitely confirmed! |
|
@AlanBreck Since you are already pretty deep into the backport, I wouldnt wanna interfere with your code. What I can offer is looking at changes / reviewing or pair programming in a videocall to assist or even work on an unrelated branch on aiding with related topics. I think it doesnt make much sense to dive into your wip though. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
@dcousens, I'm getting failing tests on the original |
@AlanBreck I owe you one for pursuing this update / PR |
|
Hi @dcousens! Just nudging on the above for guidance on tests. |
|
sorry I missed that request, I am running the CI now to see what comes up |
|
Thanks, @dcousens! Any guidance on how to proceed with the test results would be greatly appreciated. Thank you! |
|
Thanks for your work on this, @emmatown! Any direction on those last 3 failing tests? |
|
@AlanBreck @MauriceArikoglu not yet, are you able to run the tests locally? |
I am, but I wasn't able to get clean running tests for the base branch, so it's difficult to know what exactly is broken due to this PR and what is irrelevant. |
|
@AlanBreck I have a fix on my local but cannot commit to your repo. Can you invite me so I can push the fix to your branch here? |
|
@MauriceArikoglu, just sent an invite. |
@dcousens yes. i pushed a fix |
@MauriceArikoglu, I'm still getting a lot of failed tests. Seems that most are related to problems connecting to |
|
Seems to be resolved! Can we fix the linting and we should be good to land this |
@dcousens, any theories as to why I'd be getting this? Output below: Output
|
|
@AlanBreck are you sandboxed or running in Docker or similar? Firewall? |
@AlanBreck what version of node are you using? I tested with 20.19 - similar to what CI has configured |
|
@dcousens looking good now. Do you have an idea when we can expect this to land? |
@dcousens, no VPN, firewall, or docker container at use. While the tests are running, I'm also able to visit localhost:3000`.
Tried downgrading to |
This is an initial pass using Claude to port the changes from #9421 into the
v6branch.