Skip to content

Fix themed status-bar/notch color rendering as white after SwiftUI migration#4761

Merged
bgoncal merged 2 commits into
mainfrom
copilot/fix-status-bar-color-issue
Jun 17, 2026
Merged

Fix themed status-bar/notch color rendering as white after SwiftUI migration#4761
bgoncal merged 2 commits into
mainfrom
copilot/fix-status-bar-color-issue

Conversation

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
CleanShot 2026-06-17 at 16 52 58@2x

Copilot AI changed the title [WIP] Fix status bar color issue on 2026.2054 Fix themed status-bar/notch color rendering as white after SwiftUI migration Jun 17, 2026
Copilot AI requested a review from bgoncal June 17, 2026 11:43
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unused L10n strings detected

Found 21 unused localization strings in the codebase.

Click to see details
Parsing Strings.swift...
Found 1654 L10n strings

Reading all Swift source code...
Read 5681289 characters of Swift code

Checking for unused strings...
Checked 100/1654 strings...
Checked 200/1654 strings...
Checked 300/1654 strings...
Checked 400/1654 strings...
Checked 500/1654 strings...
Checked 600/1654 strings...
Checked 700/1654 strings...
Checked 800/1654 strings...
Checked 900/1654 strings...
Checked 1000/1654 strings...
Checked 1100/1654 strings...
Checked 1200/1654 strings...
Checked 1300/1654 strings...
Checked 1400/1654 strings...
Checked 1500/1654 strings...
Checked 1600/1654 strings...

================================================================================
UNUSED STRINGS REPORT
================================================================================

Found 21 unused strings:


ACTIONSCONFIGURATOR:
  - L10n.ActionsConfigurator.Action.createAutomation
    Key: actions_configurator.action.create_automation
    Line: 132
  - L10n.ActionsConfigurator.VisualSection.sceneDefined
    Key: actions_configurator.visual_section.scene_defined
    Line: 172
  - L10n.ActionsConfigurator.VisualSection.serverDefined
    Key: actions_configurator.visual_section.server_defined
    Line: 178

APPINTENTS:
  - L10n.AppIntents.WidgetAction.actionsParameterConfiguration
    Key: app_intents.widget_action.actions_parameter_configuration
    Line: 606

CAMERA:
  - L10n.Camera.serverNotFound
    Key: camera.server_not_found
    Line: 764
  - L10n.Camera.snapshotFailed
    Key: camera.snapshot_failed
    Line: 766

CAMERALIST:
  - L10n.CameraList.noArea
    Key: camera_list.no_area
    Line: 771
  - L10n.CameraList.searchPlaceholder
    Key: camera_list.search_placeholder
    Line: 773

CAMERAS:
  - L10n.Cameras.dragToReorder
    Key: cameras.drag_to_reorder
    Line: 829

SETTINGSDETAILS:
  - L10n.SettingsDetails.Actions.ActionsSynced.footerNoActions
    Key: settings_details.actions.actions_synced.footer_no_actions
    Line: 3844
  - L10n.SettingsDetails.Actions.Scenes.customizeAction
    Key: settings_details.actions.scenes.customize_action
    Line: 3862

URLHANDLER:
  - L10n.UrlHandler.Error.actionNotFound
    Key: url_handler.error.action_not_found
    Line: 4675

WIDGETS:
  - L10n.Widgets.Controls.Automations.placeholderTitle
    Key: widgets.controls.automations.placeholder_title
    Line: 5727
  - L10n.Widgets.Controls.Button.placeholderTitle
    Key: widgets.controls.button.placeholder_title
    Line: 5735
  - L10n.Widgets.Controls.Cover.placeholderTitle
    Key: widgets.controls.cover.placeholder_title
    Line: 5745
  - L10n.Widgets.Controls.Fan.placeholderTitle
    Key: widgets.controls.fan.placeholder_title
    Line: 5755
  - L10n.Widgets.Controls.Light.placeholderTitle
    Key: widgets.controls.light.placeholder_title
    Line: 5765
  - L10n.Widgets.Controls.Scenes.placeholderTitle
    Key: widgets.controls.scenes.placeholder_title
    Line: 5919
  - L10n.Widgets.Controls.Scripts.placeholderTitle
    Key: widgets.controls.scripts.placeholder_title
    Line: 5931
  - L10n.Widgets.Controls.Switch.placeholderTitle
    Key: widgets.controls.switch.placeholder_title
    Line: 5939

ROOT:
  - L10n.noArea
    Key: no_area
    Line: 36

================================================================================
Total unused: 21
================================================================================

To clean up these strings, manually remove them from the Localizable.strings files
and regenerate Strings.swift using SwiftGen.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@12aa9c9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4761   +/-   ##
=======================================
  Coverage        ?   44.92%           
=======================================
  Files           ?      275           
  Lines           ?    16720           
  Branches        ?        0           
=======================================
  Hits            ?     7512           
  Misses          ?     9208           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bgoncal bgoncal force-pushed the copilot/fix-status-bar-color-issue branch from 559e7cc to 7787d40 Compare June 17, 2026 14:45
@bgoncal bgoncal marked this pull request as ready for review June 17, 2026 14:51
Copilot AI review requested due to automatic review settings June 17, 2026 14:51
@bgoncal bgoncal enabled auto-merge (squash) June 17, 2026 14:51
@bgoncal bgoncal linked an issue Jun 17, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the themed status-bar/notch area rendering white after the SwiftUI migration by changing how the theme color layer is drawn behind the web view.

Changes:

  • Replace the zero-height status bar Color overlay with a full-bleed Color(...).ignoresSafeArea() rendered behind the content.
  • Switch from .overlay(alignment: .top) to .background(...) so the top safe-area inset reliably shows the theme color when enabled.

Comment on lines +29 to +32
/// A theme-colored layer filling the top safe-area inset above the web view. Shown only when
/// `overlayState` publishes a color (iOS, edge-to-edge off), in which case the web view's top is inset to
/// sit below it. Drawn full-bleed behind the web view so only the otherwise-uncovered status-bar inset
/// shows the color — the web view (opaque) covers everything below the top inset.
@bgoncal bgoncal merged commit 59aabce into main Jun 17, 2026
13 checks passed
@bgoncal bgoncal deleted the copilot/fix-status-bar-color-issue branch June 17, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testflight feedback: Status bar wrong color issue on 2026.2054

3 participants