Fix themed status-bar/notch color rendering as white after SwiftUI migration#4761
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix status bar color issue on 2026.2054
Fix themed status-bar/notch color rendering as white after SwiftUI migration
Jun 17, 2026
Contributor
|
Found 21 unused localization strings in the codebase. Click to see detailsTo clean up these strings, manually remove them from the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
=======================================
Coverage ? 44.92%
=======================================
Files ? 275
Lines ? 16720
Branches ? 0
=======================================
Hits ? 7512
Misses ? 9208
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
559e7cc to
7787d40
Compare
bgoncal
approved these changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the themed status-bar/notch area rendering white after the SwiftUI migration by changing how the theme color layer is drawn behind the web view.
Changes:
- Replace the zero-height status bar
Coloroverlay with a full-bleedColor(...).ignoresSafeArea()rendered behind the content. - Switch from
.overlay(alignment: .top)to.background(...)so the top safe-area inset reliably shows the theme color when enabled.
Comment on lines
+29
to
+32
| /// A theme-colored layer filling the top safe-area inset above the web view. Shown only when | ||
| /// `overlayState` publishes a color (iOS, edge-to-edge off), in which case the web view's top is inset to | ||
| /// sit below it. Drawn full-bleed behind the web view so only the otherwise-uncovered status-bar inset | ||
| /// shows the color — the web view (opaque) covers everything below the top inset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.