Fix/price range validation#92
Conversation
✅ Deploy Preview for smartrentsystem ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
add before and after image and follow pr template after i will merge pr |
…a-Kumar-cs/Smart-Rent-System into fix/price-range-validation s
🐞 Issue Description (Before Fix)Problem: 🎥 Before Fix Video:before.mp4✅ Fix Description (After Fix)Solution Implemented:
🎥 After Fix Video: @hitesh-kumar123 |
|
resolve conflicts |
Harsh63870
left a comment
There was a problem hiding this comment.
do see these issues:
Don’t mutate state in checkInput (filters.priceMin/priceMax). Use setFilters and convert inputs to Number.
Fix string/number comparisons and show validation longer than 300ms (or keep persistent until corrected).
Remove no-op debug forEach blocks.
Verify category-scroller UI changes and ensure .range-input-error CSS exists.
|
@Nandha-Kumar-cs please follow issue template update create issue according issues template i have not understand what you contribute in my project after make pr i am not satisfied and not meaningful contributions i canceled your pull request |
|
@hitesh-kumar123 This is my first open-source contribution, and I’m still learning the correct process. I understand now that my contribution was not aligned with your project’s expectations. I’ll make sure to follow the issue template properly and contribute more meaningfully in the future. |
Harsh63870
left a comment
There was a problem hiding this comment.
heyy
in the checkInput you do filters.priceMin = "" / filters.priceMax = "". that mutates state directly and will cause inconsistent UI and bugs....
multiple leftover forEach(() => {}) and empty blocks....
comparisons like value < PRICE_MIN or value > filters.priceMax are unsafe (string vs number) and will produce incorrect result...
|
@Harsh63870
|
…System into fix/price-range-validation
…System into fix/price-range-validation
…a-Kumar-cs/Smart-Rent-System into fix/price-range-validation
✅ Deploy Preview for smartrentsystem ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Description
Add price range validation
Related issue
Closes #26
How to test
Happy to make any requested changes.