tests: cover NSParagraphStyle tab stop handling#471
Merged
fredkiefer merged 1 commit intoJul 12, 2026
Conversation
DTW-Thalion
force-pushed
the
tests/nsparagraphstyle-tabstops
branch
2 times, most recently
from
bc16e29 to
5c080f1
Compare
The existing tab stop test covers archiving; this covers the behaviour: the default twelve tab stops every 28 points and the zero default interval, setTabStops: sorting the stops by location, addTabStop: keeping them in order, removeTabStop:, and setDefaultTabInterval:.
DTW-Thalion
force-pushed
the
tests/nsparagraphstyle-tabstops
branch
from
5c080f1 to
9049e11
Compare
fredkiefer
reviewed
Jul 12, 2026
| tab(CGFloat loc) | ||
| { | ||
| return [[[NSTextTab alloc] initWithType: NSLeftTabStopType | ||
| location: loc] autorelease]; |
Member
There was a problem hiding this comment.
It would be great to use the AUTORELEASE macro here.
fredkiefer
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing tab stop test covers archiving and a decode regression; this
covers the behaviour: the default twelve tab stops every 28 points and the
zero default interval, setTabStops: sorting the stops by location,
addTabStop: keeping them in order wherever a new stop belongs,
removeTabStop:, and setDefaultTabInterval:.