tests: cover the NSSliderCell tick mark values#465
Merged
Conversation
DTW-Thalion
force-pushed
the
tests/nsslidercell-ticks
branch
from
a3a7375 to
821f761
Compare
fredkiefer
reviewed
Jul 12, 2026
| } | ||
|
|
||
| /* The restrict-to-ticks flag round-trips. */ | ||
| [cell setAllowsTickMarkValuesOnly: YES]; |
Member
There was a problem hiding this comment.
Both slider cells are never released. Also this bit of code could be moved up a bit to keep the two separate d.
Contributor
Author
There was a problem hiding this comment.
Both cells are now autoreleased, and the flag round-trip is moved up so the second cell stands on its own.
minMax.m covers value clamping to the minimum and maximum; this covers the tick mark values, which it does not: the tick mark count, tickMarkValueAtIndex: spacing and its out-of-range exception, and closestTickMarkValueToValue: snapping a value to the nearest tick (rounding halves towards positive infinity and clamping out-of-range values to the end ticks), plus the no-tick and single-tick cases.
DTW-Thalion
force-pushed
the
tests/nsslidercell-ticks
branch
from
821f761 to
c9d5c9e
Compare
fredkiefer
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minMax.m covers value clamping to the minimum and maximum. This covers the
tick mark values, which it does not: the tick mark count,
tickMarkValueAtIndex: spacing and its out-of-range exception, and
closestTickMarkValueToValue: snapping a value to the nearest tick (rounding
halves towards positive infinity and clamping out-of-range values to the
end ticks), plus the no-tick and single-tick cases.