tests: cover the NSButtonCell state and value coupling#464
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
A button cell has no separate value: its int, object and string value are derived from the cell state, and setting any of them sets the state. This covers setIntValue reducing to a state, the state driving int/object/float/ string value, mixed state carried as -1, and setObjectValue mapping nil, numbers and empty strings to the state. The existing NSButtonCell test only covers encoding.
DTW-Thalion
force-pushed
the
tests/nsbuttoncell-state-value
branch
from
d68e353 to
258ba60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A button cell has no separate value: its int, object and string value are
derived from the cell state, and setting any of them sets the state. This
covers setIntValue reducing to a state (non-zero to on, so 5 reads back 1),
the state driving int/object/float/string value, mixed state carried
through the value as -1, and setObjectValue mapping nil, numbers and empty
strings to the state. The existing NSButtonCell test only covers encoding.