fix: raise mattpocock-skills-reviewer daily AIC budget to 10K#39061
Conversation
…iewer Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #39061 does not have the "implementation" label and has 0 new lines of code in business logic directories (≤100 threshold). No custom design-gate config present. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
There was a problem hiding this comment.
Pull request overview
This PR raises the daily AI Credits (AIC) guardrail for the mattpocock-skills-reviewer Agentic Workflow so it won’t block after exceeding the previous ~5K/day default threshold, and it regenerates the compiled lock workflow to reflect that new budget.
Changes:
- Added
max-daily-ai-credits: 10000to the workflow’s frontmatter configuration. - Regenerated the corresponding
.lock.ymloutput soGH_AW_MAX_DAILY_AI_CREDITSis set to10000in the compiled workflow.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/mattpocock-skills-reviewer.md | Sets the workflow’s daily AIC budget to 10,000 via frontmatter. |
| .github/workflows/mattpocock-skills-reviewer.lock.yml | Updates compiled workflow output to enforce the new 10,000 AIC limit at runtime. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /diagnose — approving. The fix is correct, minimal, and consistent with repo conventions.
📋 Key Themes & Highlights
Root Cause
The mattpocock-skills-reviewer workflow lacked an explicit max-daily-ai-credits frontmatter field, defaulting to ${{ vars.GH_AW_DEFAULT_MAX_DAILY_AI_CREDITS || '5000' }}. With real-world usage reaching 5.4K, the workflow was reliably blocked.
Assessment
- ✅ Root cause correctly identified and directly addressed (limit too low → raise it)
- ✅ Value of 10K matches virtually all other PR review workflows in this repo (verified across ~40+ workflow files)
- ✅ Lock file properly regenerated via
make recompile— frontmatter hash updated, body hash unchanged confirms only frontmatter changed - ✅ Hardcoded
"10000"in the lock file is expected gh-aw compilation behaviour:max-daily-ai-creditsin frontmatter always compiles to a literal
One Optional Note
Setting max-daily-ai-credits explicitly in frontmatter intentionally decouples this workflow from the GH_AW_DEFAULT_MAX_DAILY_AI_CREDITS repo variable. That is the right call here — just worth noting for operators who might expect the variable to take effect in future.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 140.8 AIC · ⌖ 13.4 AIC · ⊞ 27.8K
The
mattpocock-skills-reviewerworkflow was blocked after consuming 5.4K AI Credits against its default 5K daily guardrail threshold.Changes
mattpocock-skills-reviewer.md: Addedmax-daily-ai-credits: 10000to frontmatter — aligns with the budget used by other PR review workflows in this repomattpocock-skills-reviewer.lock.yml: Regenerated viamake recompile