docs(js): Update react router server instrumentation#18391
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
s1gr1d
approved these changes
Jun 12, 2026
nicohrubec
approved these changes
Jun 12, 2026
Resolve conflicts in React Router instrumentation docs: - Keep deletion of features/instrumentation-api.mdx (consolidated into manual-setup) - Keep instrumentation-API-primary server setup; drop wrapServerLoader/wrapServerAction - Preserve master's sentry init flow (index.mdx) and updated manual-setup Alert Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Comment on lines
+966
to
+969
| { | ||
| source: '/platforms/javascript/guides/react-router/features/instrumentation-api/', | ||
| destination: '/platforms/javascript/guides/react-router/manual-setup/', | ||
| }, |
Contributor
There was a problem hiding this comment.
Bug: A missing redirect for the removed /features/ documentation index page will cause 404 errors for users accessing the old URL.
Severity: LOW
Suggested Fix
Add a new redirect entry in redirects.js to forward users from the old features index path to the new manual setup guide. The entry should look like: { source: '/platforms/javascript/guides/react-router/features/', destination: '/platforms/javascript/guides/react-router/manual-setup/' }.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: redirects.js#L966-L969
Potential issue: The pull request removes the documentation page at
`docs/platforms/javascript/guides/react-router/features/index.mdx` but does not add a
corresponding redirect in `redirects.js`. While a redirect was correctly added for the
`instrumentation-api` sub-page, the parent features index page URL is now unhandled.
Consequently, any user attempting to access
`/platforms/javascript/guides/react-router/features/` from an old bookmark, a search
engine result, or an external link will receive a 404 error instead of being redirected
to the new content location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the standalone instrumentation api page and instead merge them into the manual setup docs
Documents getsentry/sentry-javascript#21470