feat: add screenshot as internal sub-API#8084
Open
philprime wants to merge 7 commits into
Open
Conversation
philprime
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philipphofmann
as code owners
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
2 tasks
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6bb1441 | 1235.07 ms | 1263.05 ms | 27.98 ms |
| 98d3984 | 1213.35 ms | 1255.76 ms | 42.41 ms |
| 05667c9 | 1209.21 ms | 1245.29 ms | 36.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6bb1441 | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 98d3984 | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 05667c9 | 24.14 KiB | 1.18 MiB | 1.16 MiB |
…rnal-api/screenshot # Conflicts: # Sources/Swift/HybridSDK/SentryInternalApi.swift
…ce' into philprime/internal-api/screenshot
…rnal-api/screenshot
Add Swift and ObjC integration tests for screenshot sub-API. Fix visionOS guard mismatch in ObjC headers: screenshot is only available on iOS/tvOS, so use !TARGET_OS_VISION guard to match the Swift implementation. Regenerate public API manifests.
The screenshot property on SentryInternalApi is only available for iOS and tvOS, but the ObjC compatibility wrapper included visionOS in its conditional compilation guard. This caused a build failure on visionOS due to accessing a non-existent property.
philprime
added a commit
that referenced
this pull request
Jun 17, 2026
Add Swift and ObjC integration tests for SentryInternalViewHierarchyApi matching the pattern from the screenshot API tests in PR #8084.
…rnal-api/screenshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentryInternalScreenshotApisub-API withcapture() -> [Data]?for hybrid SDKsSentryObjCInternalScreenshotApi)!TARGET_OS_VISIONto match Swift implementationTest plan
make build-iospassesSentryInternalScreenshotApiTestsSentryInternalScreenshotApiIntegrationTestsSentryObjCInternalScreenshotApiIntegrationTestsStacked PR 3/5 for internal API phase 2.
#skip-changelog
Closes #8089