ci: add Xcode 27 SPM build workflow#8030
Conversation
itaybre
requested review from
NinjaLikesCheez,
noahsmartin,
philipphofmann and
philprime
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ebf918. Configure here.
| - name: Setup Xcode | ||
| uses: ./.github/actions/setup-xcode | ||
| with: | ||
| version: "27" |
There was a problem hiding this comment.
Beta Xcode excluded during selection
High Severity
The workflow runs on the xcode-beta pool and requests Xcode 27, but ./.github/actions/setup-xcode runs scripts/ci-select-xcode.sh, which removes beta/RC lines from xcodes installed before resolving the version. Prerelease Xcode 27 on that pool may never match, so Setup Xcode can fail or select a non-27 toolchain and the SPM matrix never validates Xcode 27.
Reviewed by Cursor Bugbot for commit 4ebf918. Configure here.
There was a problem hiding this comment.
This appears to be correct (but I assume bitrise are installing to a different path) - maybe we should add a '--allow-prerelease' or similar flag to the ci-select-xcode.sh script
| version: "27" | ||
| - name: Build SPM (${{ matrix.platform }}) | ||
| run: | | ||
| set -o pipefail && NSUnbufferedIO=YES xcodebuild \ |
There was a problem hiding this comment.
m: Reason not to use our sentry-xcodebuild.sh wrapper script?
There was a problem hiding this comment.
I just cloned the build-spm step, we should update both
3 participants
Summary
#skip-changelog