Skip to content

rfc1: Assisted-by example should use periods#528

Open
garlick wants to merge 1 commit into
flux-framework:masterfrom
garlick:ai_tweak
Open

rfc1: Assisted-by example should use periods#528
garlick wants to merge 1 commit into
flux-framework:masterfrom
garlick:ai_tweak

Conversation

@garlick

@garlick garlick commented Jul 8, 2026

Copy link
Copy Markdown
Member

Problem: the Assisted-by example uses opus-4-8 but it's probably more natural to use periods.

Change the example.

Problem: the Assisted-by example uses opus-4-8 but it's probably more
natural to use periods.

Change the example.
@mergify

mergify Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

⚠️ linkcheck failed with status code 2

@chu11 chu11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grondo

grondo commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

One point that might need clarification: can MODEL_VERSION contain whitespace?

@chu11

chu11 commented Jul 8, 2026

Copy link
Copy Markdown
Member

One point that might need clarification: can MODEL_VERSION contain whitespace?

On that note, do we want to be specific about format or perhaps keep it semi broadly open?

In flux-framework/flux-core#7715 @grondo thought it should be Claude:claude-opus-4.8, but when I asked Claude to put in a trailer, it chose Claude:Opus 4.8. Version can be somewhat ambiguous or broad.

@wihobbs

wihobbs commented Jul 8, 2026

Copy link
Copy Markdown
Member

One thing I just noticed is the LKML "standard" isn't cited anywhere on the page even though that's what we're using. Perhaps it should go in "further reading"?

Saying "follow the LKML guidelines" is, IMHO, as unambiguous as you can get for this.

@garlick

garlick commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

I'm not sure we need to cite the kernel here, or get too prescriptive. The kernel's guidelines are also pretty open ended about things like periods and spaces.

@grondo

grondo commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Ok, sounds like "Claude: Opus 4.8" is just fine. The example implies an attempt to avoid whitespace (e.g. to perhaps allow later parsing when there are multiple items in the Assisted-by: line), but sounds like that isn't necessary. That was my only point of confusion.

@garlick

garlick commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

works for me. Hopefully I'm not being shortsighted about parsing, but unless were to specify a full on schema like SPDX, it seems like it doesn't matter much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants