Skip to content

This PR is to add comments to freeStorageBytesInternal in pkg/ddc/alluxio/ufs_internal.go. #6038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lingfeib wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

This PR is to add comments to freeStorageBytesInternal in pkg/ddc/alluxio/ufs_internal.go. #6038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/ddc/alluxio/ufs_internal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@
return
}


@cheyang cheyang Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: There is an extra blank line before the comment block. Go convention is to have exactly one blank line between top-level declarations. Consider removing the extra blank line so the comment sits directly after the single blank line separating it from the previous function.

// freeStorageBytesInternal returns the amount of free storage space (in bytes) within the Alluxio filesystem.
// It currently returns zero values as the implementation has not been completed.
// TODO: implement the query logic to retrieve the actual free bytes from the Alluxio master.

Check warning on line 47 in pkg/ddc/alluxio/ufs_internal.go

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 


See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ7bZNVo-MsgTZ5gIbhi&open=AZ7bZNVo-MsgTZ5gIbhi&pullRequest=6036
func (e *AlluxioEngine) freeStorageBytesInternal() (value int64, err error) {
return
}
Expand Down
Loading