Skip to content

fix: Make pytest config compatible with newer pytest#5779

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
antznette1:fix/pytest-windows-test-config
Jul 10, 2026
Merged

fix: Make pytest config compatible with newer pytest#5779
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
antznette1:fix/pytest-windows-test-config

Conversation

@antznette1

@antznette1 antznette1 commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • Update sdk/python/pytest.ini to avoid relying on internal _pytest.warning_types.* warning classes (breaks on newer pytest).
  • Fix Windows multiprocessing start method selection (sys.platform is win32, not windows).
  • Avoid importing optional integration-only dependencies at conftest.py import time (so test collection doesn’t hard-fail when optional deps aren’t installed).

Why we need it:

  • Unblocks local test runs on newer pytest versions and improves Windows contributor experience.

Testing

  • Local: verified pytest no longer fails early due to invalid warning class / Windows fork start method.

Open with Devin

@antznette1 antznette1 requested a review from a team as a code owner December 16, 2025 16:38
@ntkathole ntkathole changed the title fix: make pytest config compatible with newer pytest fix: Make pytest config compatible with newer pytest Dec 23, 2025
@ntkathole ntkathole force-pushed the fix/pytest-windows-test-config branch from e5ef90b to 99c742d Compare December 23, 2025 07:59
@ntkathole

Copy link
Copy Markdown
Member

@antznette1 Can you please fix the linting ? Thanks

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 081c356 to 1835d0f Compare January 3, 2026 01:13
@antznette1

Copy link
Copy Markdown
Contributor Author

@antznette1 Can you please fix the linting ? Thanks

@ntkathole

I have done it.

@franciscojavierarceo

Copy link
Copy Markdown
Member

@antznette1 looks like you need to resolve conflicts please.

@franciscojavierarceo

Copy link
Copy Markdown
Member

@copilot can you help resolve the conflicts and remove the commits not related to this branch?

@antznette1

Copy link
Copy Markdown
Contributor Author

@antznette1 looks like you need to resolve conflicts please.

Good day Sir,
Please, I'd love to get the review on the PR

@franciscojavierarceo

Copy link
Copy Markdown
Member

@antznette1 there are quite a number of conflicts that need to be resolved 😅

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 1835d0f to 11f0ff0 Compare January 26, 2026 15:37
devin-ai-integration[bot]

This comment was marked as resolved.

@antznette1

Copy link
Copy Markdown
Contributor Author

@antznette1 there are quite a number of conflicts that need to be resolved 😅

I have worked on the conflicts; it's not conflicted anymore

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 11f0ff0 to 2abd8be Compare January 26, 2026 16:21
devin-ai-integration[bot]

This comment was marked as resolved.

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 30da656 to 8a60f75 Compare February 4, 2026 11:13
@ntkathole ntkathole force-pushed the fix/pytest-windows-test-config branch from 8a60f75 to 6c504a8 Compare February 4, 2026 11:36
@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 6c504a8 to 06b64f4 Compare March 31, 2026 23:47
devin-ai-integration[bot]

This comment was marked as resolved.

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from c5ad043 to 4669ee6 Compare April 1, 2026 01:10
@antznette1

Copy link
Copy Markdown
Contributor Author

@ntkathole ,
Checks complete

@antznette1

Copy link
Copy Markdown
Contributor Author

@ntkathole ,
Please can I get a review to this PR?

@antznette1

antznette1 commented Apr 19, 2026

Copy link
Copy Markdown
Contributor Author

Good day,
please, I am still waiting for a review on this PR

@antznette1

Copy link
Copy Markdown
Contributor Author

Hello

@franciscojavierarceo franciscojavierarceo force-pushed the fix/pytest-windows-test-config branch 3 times, most recently from 0c3f6a4 to dddcb00 Compare July 10, 2026 13:46
@franciscojavierarceo franciscojavierarceo force-pushed the fix/pytest-windows-test-config branch from dddcb00 to 4aa3408 Compare July 10, 2026 13:48
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo franciscojavierarceo force-pushed the fix/pytest-windows-test-config branch from 4aa3408 to d99adc2 Compare July 10, 2026 13:54
@franciscojavierarceo franciscojavierarceo merged commit a57ea33 into feast-dev:master Jul 10, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants