test: drop mock of getEnvVar#398
Merged
Merged
Conversation
jkleinsc
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mock prevents testing some code paths because it's just returning
undefined. There's no reason to do a mock here, we can exercise the real util code.Removing it exposes that
COMMITTER_USER_NAMEisn't set in tests and is undocumented. Looking at the historical context, it looks like it was originally used forelectron-bot, but we haven't used that account in ages, so let's just drop theCOMMITTER_USER_NAMEusage as part of this.