Cancel Quick Access compute on dispose to stop orphaned jobs#4145
Open
vogella wants to merge 1 commit into
Open
Cancel Quick Access compute on dispose to stop orphaned jobs#4145vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
doDispose() left computeProposalsJob running, so a closed dialog kept querying providers and lingered in COMPUTE_JOB_FAMILY. The setUp warmup made this visible: it set "t", waited only for the first results, then closed the dialog while the lazy providers were still cold-initializing on the worker. That orphaned job stayed in the family and, on a loaded macOS runner, could outlive a test's 30 s waitForQuickAccessResults wait, which waits for the whole family to drain (issue eclipse-platform#4009, testPreviousChoicesAvailableForExtension). Cancel the compute job in doDispose so a closed dialog stops computing and leaves the family promptly. Make the warmup wait for results and for the compute job to drain, so the providers' slow first query finishes in setUp rather than leaking into a test's timed wait.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doDispose()never cancelled the in-flight compute job, so a closed Quick Access dialog kept querying providers and lingered in the compute job family. The test warmup made this visible: it sets"t", waits only for the first results, then closes the dialog while the lazy providers are still cold-initializing on the worker, leaving an orphaned job in the family. On a loaded macOS runner that orphan could outlive a test's 30 s wait for the family to drain, which is thetestPreviousChoicesAvailableForExtensionflake (#4009).This cancels the compute job in
doDisposeso a closed dialog stops computing and leaves the family promptly, and makes the warmup wait for the compute to drain so the providers' slow first query finishes during setup instead of leaking into a test's timed wait. All tenQuickAccessDialogTestcases pass locally.