Consider "RMI Runtime" thread group as a user group#972
Open
trancexpress wants to merge 2 commits into
Open
Conversation
trancexpress
force-pushed
the
gh971
branch
2 times, most recently
from
3f84352 to
f676909
Compare
Contributor
Author
|
@HannesWell is there something wrong with the bot that bumps versions? Or its only running for the platform and not for JDT? |
Member
|
It's also broken on platform |
Member
|
I would say, let try this fix it as proposed. |
LSP4J calls are serviced by the "RMI Runtime" thread group. In JDK code, this group is considered a user thread group, as it can run user code (such as LSP4J calls from clients). This change adjusts JDIThread to consider the "RMI Runtime" thread group as a user thread group. This makes it possible to debug LSP4J code without turning on the system threads Debug view filter. Which in turn avoids running into Debug view updating mechanism bugs related to using filters. See: eclipse-jdt#971
Contributor
Author
It looks like its needed, there were failing checks without it. |
Contributor
Author
|
Do we proceed here @iloveeclipse ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSP4J calls are serviced by the "RMI Runtime" thread group. In JDK code, this group is considered a user thread group, as it can run user code (such as LSP4J calls from clients).
This change adjusts
JDIThreadto consider the "RMI Runtime" thread group as a user thread group. This makes it possible to debug LSP4J code without turning on the system threads Debug view filter. Which in turn avoids running into Debug view updating mechanism bugs related to using filters.See: #971