Skip to content

[24549] Remove stale tcp channels (backport #6421)#6459

Open
mergify[bot] wants to merge 1 commit into
2.14.xfrom
mergify/bp/2.14.x/pr-6421
Open

[24549] Remove stale tcp channels (backport #6421)#6459
mergify[bot] wants to merge 1 commit into
2.14.xfrom
mergify/bp/2.14.x/pr-6421

Conversation

@mergify

@mergify mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

This PR introduces logic to remove stale TCP ACCEPT type channels when the listening operation ends (Asio detects and closes the socket). We can only perform this action on ACCEPT type channels because the re-connection mechanism of the CONNECT type channels rely on detecting stale channels and try to re-establish the connection when data needs to be sent.

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #6421 done by [Mergify](https://mergify.com).

* Refs #24549: Test for removing stale channel_resources_ of finished clients

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #24549: Improve TCP clean up

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #24549: Ensure proper destruction in test

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #24549: Protect smart wait from potential data race

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #24549: Fix test

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>

---------

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
(cherry picked from commit 8188b41)
@cferreiragonz cferreiragonz added this to the v2.14.7 milestone Jun 30, 2026
@mergify mergify Bot mentioned this pull request Jun 30, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant