Make cutout dark are in tab switcher in landscape and draw content behind the gesture nav bar in tab switcher#8933
Open
catalinradoiu wants to merge 1 commit into
Conversation
…hind the gesture nav bar in tab switcher Also move the updateLayoutForDisplayCutout method to the DuckDuckGoActivity.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL:https://app.asana.com/1/137249556945/project/1211724162604201/task/1215854420455811?focus=true
Tech Design URL (if applicable):
Description
Moves the
updateLayoutForDisplayCutoutmethod fromBrowserActivityandCustomTabActivityinto the baseDuckDuckGoActivityclass, making it reusable across all activities. This method is now also called inTabSwitcherActivityto properly handle display cutout behavior during orientation changes.Additionally, navigation bar insets are now applied to the navigation bar mockup in
BrowserActivity, and the tab switcher's navigation bar insets are configured to draw behind gesture navigation.Steps to test this PR
Display Cutout Handling
BrowserActivity,CustomTabActivity, andTabSwitcherActivityNavigation Bar Insets
BrowserActivityis correctly inset (when launching the app in split omnibar mode)TabSwitcherActivity, verify the tab list draws correctly behind the gesture navigation barUI changes
Note
Low Risk
Changes are limited to window layout flags and edge-to-edge padding on browser, custom tab, and tab switcher screens; no data or security paths are touched.
Overview
Display cutout:
updateLayoutForDisplayCutoutmoves from duplicated code inBrowserActivityandCustomTabActivityintoDuckDuckGoActivity. In landscape it setsLAYOUT_IN_DISPLAY_CUTOUT_MODE_NEVERso content stays out of the notch/cutout; portrait keeps default behavior.TabSwitcherActivitynow calls this on create (when browser edge-to-edge is on), matching browser/custom-tab handling on rotation.Navigation bar insets: With edge-to-edge in
BrowserActivity, navigation bar insets are applied tonavigationBarMockup(split omnibar startup mockup). InTabSwitcherActivityfor top omnibar,applyNavigationBarInsetson the tabs container usesdrawBehindGestureNav = trueso the tab grid can extend behind the gesture navigation bar instead of stopping above it.Reviewed by Cursor Bugbot for commit 10793ca. Bugbot is set up for automated code reviews on this repo. Configure here.