fix duck ai end cta copy for custom ai onboarding#8927
Merged
LukasPaczos merged 1 commit intoJun 18, 2026
Conversation
lmac012
approved these changes
Jun 18, 2026
LukasPaczos
merged commit 16cf7c1
into
feature/lukasz/duck-ai-onboarding-native-input-compatibility
16 of 17 checks passed
lmac012
pushed a commit
that referenced
this pull request
Jun 18, 2026
Fixes a regression in #8888. The PR introduced a new end CTA for DUck.ai flow, so the custom AI copy needs to move to it. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Onboarding copy routing only; no auth, data, or core browser behavior changes. > > **Overview** > Fixes a regression where **custom AI onboarding** end messaging lived on the generic **Dax end** bubble after a separate **Duck AI end** CTA was added. > > **`DaxDuckAiEndBrandDesignUpdateBubbleCta`** now picks the description from `onboardingStore.isCustomAiOnboardingFlow()`: custom flow uses `onboardingEndCustomAiFlowDaxDialogDescription`, otherwise the standard Duck AI end string. > > **`DaxEndBrandDesignUpdateBubbleCta`** is simplified back to always using `onboardingEndDaxDialogDescription`, with the custom-flow branch and `decorateDescription` AI icon logic removed from that class. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b8b0711. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in #8888. The PR introduced a new end CTA for DUck.ai flow, so the custom AI copy needs to move to it.
Note
Low Risk
Onboarding copy routing only; no auth, data, or core browser behavior changes.
Overview
Fixes a regression where custom AI onboarding end messaging lived on the generic Dax end bubble after a separate Duck AI end CTA was added.
DaxDuckAiEndBrandDesignUpdateBubbleCtanow picks the description fromonboardingStore.isCustomAiOnboardingFlow(): custom flow usesonboardingEndCustomAiFlowDaxDialogDescription, otherwise the standard Duck AI end string.DaxEndBrandDesignUpdateBubbleCtais simplified back to always usingonboardingEndDaxDialogDescription, with the custom-flow branch anddecorateDescriptionAI icon logic removed from that class.Reviewed by Cursor Bugbot for commit b8b0711. Bugbot is set up for automated code reviews on this repo. Configure here.