Promote internal onboarding tests to release blockers#8922
Open
catalinradoiu wants to merge 1 commit into
Open
Promote internal onboarding tests to release blockers#8922catalinradoiu wants to merge 1 commit into
catalinradoiu wants to merge 1 commit into
Conversation
Move the preonboardingTest suite from the non-blocking nightly into the release-gating full suite, where failures route to the releases blocker section and gate the LGC tag (Anvil path; Metro stays informational). Apply the onboardingQuickSetupExperimentJun3 config patch in the full suite build so the tests stay deterministic; the patch only affects the internal binary the tests run on. Drop the now-unused patch and step from the non-blockers suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
LukasPaczos
approved these changes
Jun 18, 2026
| asana_releases_blocker_section_id: ${{ vars.GH_ANDROID_APP_RELEASES_PROJECT_BLOCKER_SECTION_ID }} | ||
|
|
||
| - name: Internal Onboarding Flows | ||
| id: maestro-preonboarding |
Contributor
There was a problem hiding this comment.
Suggested change
| id: maestro-preonboarding | |
| id: maestro-internal-onboarding |
| with: | ||
| maestro_api_key: ${{ secrets.ROBIN_API_KEY }} | ||
| maestro_project_id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }} | ||
| maestro_test_name: preonboarding${{ env.DI_UNDERSCORE_SUFFIX }}_${{ github.sha }} |
Contributor
There was a problem hiding this comment.
Suggested change
| maestro_test_name: preonboarding${{ env.DI_UNDERSCORE_SUFFIX }}_${{ github.sha }} | |
| maestro_test_name: internalonboarding${{ env.DI_UNDERSCORE_SUFFIX }}_${{ github.sha }} |
catalinradoiu
changed the title
catalinradoiu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1215328803756880?focus=true
Tech Design URL (if applicable):
Description
Promotes the internal onboarding (
preonboardingTest) suite from the non-blocking nightly E2E workflow to the release-gating full suite.Previously these tests only ran in
e2e-nightly-non-blockers-suite.yml— a standalone nightly cron that the LGC/release pipeline never invokes, so failures never blocked a release. They now run ine2e-nightly-full-suite.yml(called bynightly-orchestrator.yml), as a new Internal Onboarding Flows step on the internal binary. Failures therefore route to the releases blocker section and gate the Last-Good-Commit tag.The
disable_onboarding_quick_setup_experiment.jsonconfig patch — which disables the 50/50onboardingQuickSetupExperimentJun3A/B experiment to keep these tests deterministic — was moved with the suite into the full-suite build. It only affects the internal binary the tests run on:privacy-config-internalis wired viainternalImplementation, so the release/play binary ignores config patches and the existing release-binary onboarding test is unaffected. The now-unused step and patch were removed from the non-blockers suite.Steps to test this PR
CI configuration change — verify via workflow runs
UI changes
Note
Medium Risk
No app code changes, but failures in the promoted suite will now gate releases for the default AnvilDagger path until fixed or the workflow is adjusted.
Overview
Internal onboarding (
preonboardingTest) Maestro flows move from the standalone non-blocker nightly workflow into the release-gating full E2E suite, so they run on the nightly orchestrator path and can block Last-Good-Commit when AnvilDagger is used.The full suite adds an Internal Onboarding Flows step against the internal APK (with
is_release_blockerand releases Asana routing, same pattern as other blocker suites). Assembly there now appliesdisable_onboarding_quick_setup_experiment.jsonviagradle_flagsso preonboarding runs stay deterministic.The non-blocker workflow drops the preonboarding step and that config patch from its assemble flags (duckplayer patch only remains).
Reviewed by Cursor Bugbot for commit 65e06da. Bugbot is set up for automated code reviews on this repo. Configure here.