Set Duck Player to Never for new users#8894
Open
CrisBarreiro wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d85af13. Configure here.
d85af13 to
f6cf70d
Compare
f6cf70d to
09f388e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/task/1215652881336097?focus=true
Tech Design URL (if applicable):
Important
If
version.propertiesis lower than5.283.1.6, update it to5.284.0, otherwise, Ad Blocking will be offDescription
Set Duck Player to Never for new users
Steps to test this PR
Feature disabled, new user > Ask Every Time
Ask Every TimeFeature enabled, disabled by default, new user > Ask Every Time
Ask Every TimeFeature enabled, enabled by default, existing user > Ask Every Time
NeverFeature enabled, enabled by default, new user > Never
NeverUI changes
n/a
Patches
Patch 1 ad blocking enabled and disabled by default
Patch 2: ad blocking enabled and enabled by default
Note
Medium Risk
Changes first-run defaults and YouTube navigation behavior for new users under remote-config rollout; existing users with stored prefs are mostly unchanged, but the new init-time write depends on toggle timing.
Overview
Duck Player no longer ties default private-player mode to live ad-blocking consent via
AdBlockingStatusChecker. When preferences are unset,getUserPreferencesandobserveUserPreferencesnow always surfaceAlwaysAskinstead of sometimes defaulting toDisabled.For fresh installs only,
RealDuckPlayerwatches stored preferences plusAdBlockingExtensionFeature(selfandenabledByDefault) and persistsDisabled(Never) once when the user has no stored mode and the extension rollout is on with enabled-by-default—without overwriting an existing choice.Tests swap the status-checker mocks for feature toggles and
AppBuildConfig, and add coverage for the rollout persistence guards.Reviewed by Cursor Bugbot for commit 09f388e. Bugbot is set up for automated code reviews on this repo. Configure here.