Skip to content

Set Duck Player to Never for new users#8894

Open
CrisBarreiro wants to merge 1 commit into
developfrom
feature/cris/duckplayer-disable-default-new-users
Open

Set Duck Player to Never for new users#8894
CrisBarreiro wants to merge 1 commit into
developfrom
feature/cris/duckplayer-disable-default-new-users

Conversation

@CrisBarreiro

@CrisBarreiro CrisBarreiro commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Task/Issue URL: https://app.asana.com/1/137249556945/task/1215652881336097?focus=true
Tech Design URL (if applicable):

Important

If version.properties is lower than 5.283.1.6, update it to 5.284.0, otherwise, Ad Blocking will be off

Description

Set Duck Player to Never for new users

Steps to test this PR

Feature disabled, new user > Ask Every Time

  • Fresh install the app
  • Complete the onboarding
  • Open Duck Player settings
  • Check state is Ask Every Time

Feature enabled, disabled by default, new user > Ask Every Time

  • Apply Patch 1 ad blocking enabled and disabled by default
  • Fresh install the app
  • Complete the onboarding
  • Open YouTube Ad Blocking > Duck Player settings
  • Check state is Ask Every Time

Feature enabled, enabled by default, existing user > Ask Every Time

  • Install the app from develop
  • Complete the onboarding
  • Switch to this branch
  • Apply Patch 2: ad blocking enabled and enabled by default
  • Fresh install the app
  • Complete the onboarding
  • Open YouTube Ad Blocking > Duck Player settings
  • Check state is Never

Feature enabled, enabled by default, new user > Never

  • Apply Patch 2: ad blocking enabled and enabled by default
  • Fresh install the app
  • Complete the onboarding
  • Open YouTube Ad Blocking > Duck Player settings
  • Check state is Never

UI changes

n/a

Patches

Patch 1 ad blocking enabled and disabled by default

Subject: [PATCH] ad blocking enabled and disabled by default
---
Index: privacy-config/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/privacy-config/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt b/privacy-config/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt
--- a/privacy-config/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt	(revision d85af13fffb7404a41cbe6a1ba587521ca6d9af4)
+++ b/privacy-config/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt	(date 1781614366554)
@@ -29,4 +29,4 @@
     TrackingParametersFeatureName("trackingParameters"),
 }
 
-const val PRIVACY_REMOTE_CONFIG_URL = "https://staticcdn.duckduckgo.com/trackerblocking/config/v5/android-config.json"
+const val PRIVACY_REMOTE_CONFIG_URL = "https://gist.githubusercontent.com/CrisBarreiro/91d53b9f9411079f57d13bcbe02c3750/raw/2729c8de3c1090cb967a2fabc283a381d87961e2/android-config.json"

Patch 2: ad blocking enabled and enabled by default


Note

Medium Risk
Changes first-run defaults and YouTube navigation behavior for new users under remote-config rollout; existing users with stored prefs are mostly unchanged, but the new init-time write depends on toggle timing.

Overview
Duck Player no longer ties default private-player mode to live ad-blocking consent via AdBlockingStatusChecker. When preferences are unset, getUserPreferences and observeUserPreferences now always surface AlwaysAsk instead of sometimes defaulting to Disabled.

For fresh installs only, RealDuckPlayer watches stored preferences plus AdBlockingExtensionFeature (self and enabledByDefault) and persists Disabled (Never) once when the user has no stored mode and the extension rollout is on with enabled-by-default—without overwriting an existing choice.

Tests swap the status-checker mocks for feature toggles and AppBuildConfig, and add coverage for the rollout persistence guards.

Reviewed by Cursor Bugbot for commit 09f388e. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d85af13. Configure here.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer-disable-default-new-users branch from d85af13 to f6cf70d Compare June 16, 2026 15:39
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer-disable-default-new-users branch from f6cf70d to 09f388e Compare June 16, 2026 16:21
@CrisBarreiro CrisBarreiro requested a review from cmonfortep June 17, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants