Add DaxScaffold and lint rule enforcing it over Material Scaffold#8824
Open
GerardPaligot wants to merge 1 commit into
Open
Add DaxScaffold and lint rule enforcing it over Material Scaffold#8824GerardPaligot wants to merge 1 commit into
GerardPaligot wants to merge 1 commit into
Conversation
e85c9c0 to
e4eceab
Compare
a56f03f to
8430706
Compare
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
e4eceab to
833f60f
Compare
8430706 to
034c083
Compare
833f60f to
1d197a7
Compare
034c083 to
42a17ae
Compare
1d197a7 to
d7bf562
Compare
42a17ae to
62f3e4b
Compare
3 tasks
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d7bf562. Configure here.
d7bf562 to
1de1820
Compare
62f3e4b to
0eaf678
Compare
1de1820 to
c490224
Compare
0eaf678 to
2117fd8
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1215496415658080/task/1215518884361562
Description
Adds a DuckDuckGo-themed Compose scaffold and a lint rule that enforces its use.
DaxScaffoldwraps Material3Scaffoldwith DuckDuckGo default container/content colors and content window insets.NoMaterial3ScaffoldUsagelint rule (error severity) that directs usage toDaxScaffoldeverywhere except the design system modules, mirroring the existing Material3 switch/checkbox/radio rules.Steps to test this PR
Design system screen
UI changes
Note
Low Risk
Changes are confined to new design-system API, internal demo UI, and lint enforcement with no production feature logic.
Overview
Introduces
DaxScaffold, a design-system wrapper around Material3Scaffoldthat applies DuckDuckGo theme container and content colors (viaDaxScaffoldDefaults) while keeping the usual top/bottom bar, snackbar, insets, and content slot API.The internal Design System → Layout catalog gains a Scaffold entry (
Component.SCAFFOLD, layout +ScaffoldComponentViewHolder) demoingDaxSearchTopAppBarwith search state over placeholder content.A new
NoMaterial3ScaffoldUsagelint check (error severity, registered inDuckDuckGoIssueRegistry) flags directandroidx.compose.material3.Scaffoldcalls outsidedesign-system/design-system-internal, with unit tests matching the existing Material3 component lint pattern.Reviewed by Cursor Bugbot for commit c490224. Bugbot is set up for automated code reviews on this repo. Configure here.