Skip to content

Use Samples repo for http-log-enricher#37323

Merged
wadepickett merged 5 commits into
dotnet:mainfrom
timdeschryver:issues/37208
Jul 9, 2026
Merged

Use Samples repo for http-log-enricher#37323
wadepickett merged 5 commits into
dotnet:mainfrom
timdeschryver:issues/37208

Conversation

@timdeschryver

@timdeschryver timdeschryver commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Comment thread aspnetcore/fundamentals/http-logging/http-log-enricher.md Outdated

@wadepickett wadepickett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timdeschryver, great work! I only found one very minor item, an extra blank line. See inline suggestion.

@wadepickett wadepickett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming very minor line suggestion fix. Actually, I'll just remove the extra blank line in a commit so we can get this merged.

Comment thread aspnetcore/fundamentals/http-logging/http-log-enricher.md
@wadepickett

wadepickett commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@tdykstra or @timdeschryver , can you commit that last suggested change? Then I will not be the last to make a change and I can approve and merge. Until then I'm blocked from approve/merge.

Co-authored-by: Wade Pickett <wpickett@microsoft.com>
@timdeschryver

Copy link
Copy Markdown
Contributor Author

@wadepickett done ✔️

@wadepickett wadepickett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, merged, live in a few minutes.

Thanks @timdeschryver!

@wadepickett wadepickett merged commit 4135d66 into dotnet:main Jul 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Enrich HTTP request logs article to use sample from samples repo

2 participants