Skip to content

[DO NOT MERGE] chore: adding mise#259

Open
ibuziuk wants to merge 1 commit into
mainfrom
mise
Open

[DO NOT MERGE] chore: adding mise#259
ibuziuk wants to merge 1 commit into
mainfrom
mise

Conversation

@ibuziuk

@ibuziuk ibuziuk commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

https://mise.en.dev/installing-mise.html

Summary by CodeRabbit

  • New Features
    • Added the mise runtime manager to the UBI 9 and UBI 10 container images.
    • Installation now includes repository setup and post-install cleanup to keep images lean.

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk requested review from SDawley, dkwon17 and svor as code owners July 2, 2026 16:09
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Both universal/ubi9/Dockerfile and universal/ubi10/Dockerfile are updated to install the mise runtime manager. Each adds a RUN step enabling the dnf-command(copr) plugin, activating the jdxcode/mise COPR repository, installing mise, and cleaning dnf metadata/cache directories.

Changes

Mise Installation

Layer / File(s) Summary
Add mise install step
universal/ubi9/Dockerfile, universal/ubi10/Dockerfile
Adds a RUN step after the tmux installation block that enables dnf-command(copr), activates the jdxcode/mise COPR repo, installs mise, and cleans dnf metadata/cache.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • devfile/developer-images#254: Modifies the same Dockerfiles, adding the tmux install block directly preceding this mise installation step.

Suggested labels: lgtm

Suggested reviewers: svor, tolusha, SDawley, dkwon17

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: adding mise to the Dockerfiles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mise

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tolusha

tolusha commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant check-pr-test-failures — Analyze failing CI checks, identify root causes, and suggest fixes
  • /che-ai-assistant help — Show this help message

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
universal/ubi9/Dockerfile (1)

558-564: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Unpinned mise version breaks reproducibility pattern used elsewhere.

Every other tool in this Dockerfile pins an explicit version (KAMEL_VERSION, OC_VERSION, TKN_VERSION, KUBECTL_VERSION, etc.), but dnf -y install mise pulls whatever is latest in the COPR repo at build time, making builds non-reproducible and letting an upstream COPR update silently change behavior.

Also, the COPR repo remains enabled in the final image after installation (only the dnf cache is cleaned, not the repo definition), leaving a third-party repository active at runtime.

♻️ Suggested tightening
 ## mise
 RUN dnf -y install 'dnf-command(copr)' && \
     dnf -y copr enable jdxcode/mise centos-stream+epel-next-9 && \
-    dnf -y install mise && \
+    dnf -y install mise-<PIN_VERSION> && \
+    dnf -y copr disable jdxcode/mise && \
     dnf clean all && \
     rm -rf /var/cache/dnf
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@universal/ubi9/Dockerfile` around lines 558 - 564, The mise install is
unpinned and leaves the COPR repo enabled in the final image, breaking
reproducibility and runtime hardening. Update the Dockerfile’s mise setup to
install a specific mise version in the same pattern used for KAMEL_VERSION,
OC_VERSION, and KUBECTL_VERSION, and ensure the COPR repo is removed or disabled
after installation so no third-party repo remains active in the final image.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@universal/ubi9/Dockerfile`:
- Around line 558-564: The mise install is unpinned and leaves the COPR repo
enabled in the final image, breaking reproducibility and runtime hardening.
Update the Dockerfile’s mise setup to install a specific mise version in the
same pattern used for KAMEL_VERSION, OC_VERSION, and KUBECTL_VERSION, and ensure
the COPR repo is removed or disabled after installation so no third-party repo
remains active in the final image.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 93aee4d8-4d31-41df-a35e-bf59cec8956f

📥 Commits

Reviewing files that changed from the base of the PR and between bacc1e9 and ad769bc.

📒 Files selected for processing (2)
  • universal/ubi10/Dockerfile
  • universal/ubi9/Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants