Improve element filtering: model union/intersection presets, kept count, apply indicator#628
Draft
joehart2001 wants to merge 2 commits into
Draft
Improve element filtering: model union/intersection presets, kept count, apply indicator#628joehart2001 wants to merge 2 commits into
joehart2001 wants to merge 2 commits into
Conversation
joehart2001
commented
Jun 18, 2026
| orb-v3-consv-inf-omat: | ||
| module: orb_models.inference.calculator | ||
| class_name: OrbCalc | ||
| datasets: [OMAT] |
Collaborator
Author
There was a problem hiding this comment.
unsure if this is totally correct as orb supports more elemtns than omat covers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
add model union and intersection for selected models. this is done by adding "dataset" parameter to the
models.yml, and adding the dataset to the jsonadded an element counter
add a indicator when you have unapplied changes
TODO: json needs to be updated for all datasets, same with modles.yml, but code is ready for review
Linked issue
Resolves #
Testing