Skip to content

make cores vs threads detection more robust#679

Open
jshook wants to merge 1 commit into
mainfrom
phy-cores-detect
Open

make cores vs threads detection more robust#679
jshook wants to merge 1 commit into
mainfrom
phy-cores-detect

Conversation

@jshook

@jshook jshook commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This makes detection of physical cores more robust across three key system types, on best-effort basis.
The previous logic presumed HT cores and could easily get the answer wrong on any other physical architecture.

Another related fix will delegate to PhysicalCoreExecutor DRYly, keeping thread pool sizing consistent as much as possible.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

@jshook jshook mentioned this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant