Skip to content

Legitimate bot helper#4511

Merged
buixor merged 4 commits into
waf-challenge-modefrom
legitimate-bot-helper
Jun 16, 2026
Merged

Legitimate bot helper#4511
buixor merged 4 commits into
waf-challenge-modefrom
legitimate-bot-helper

Conversation

@blotus

@blotus blotus commented Jun 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

Copy link
Copy Markdown

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@sabban sabban self-assigned this Jun 15, 2026

@sabban sabban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

func compileBotRegex(pattern string) (*regexp.Regexp, error) {
return regexp.Compile("(?i)" + pattern) // Force case insensitive match
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to add a comment to remind what the call flow is for botFileInit and LoadBotfilesFromDir:
AppsecConfig.Build() ← appsec.go:820
└── setupLegitBots(hub) ← appsec.go:866
└── LoadBotFilesFromDir() ← botfile.go:127 (once, scans legit_bots/ dir)
└── FileInit() ← helpers.go (once per file)
└── botFileInit() ← botfile.go:52 (once per JSON line)

@buixor

buixor commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

/kind enhancement
/area appsec

@buixor

buixor commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

/kind enhancement

@buixor buixor merged commit 7726a38 into waf-challenge-mode Jun 16, 2026
2 checks passed
@buixor buixor deleted the legitimate-bot-helper branch June 16, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/appsec kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants