cond::timeout now matches std::errc::timed_out#335
Merged
sgerbino merged 1 commit intoJun 24, 2026
Conversation
cond_cat::equivalent matched cond::timeout only against error::timeout, while cond::canceled also matched raw std::errc::operation_canceled. A platform or third-party timed_out code therefore compared equal to cond::canceled's analogue but not to cond::timeout. Accept std::errc::timed_out for cond::timeout so callers can compare any timeout code against the portable condition, mirroring the canceled branch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop-2 #335 +/- ##
============================================
Coverage ? 98.15%
============================================
Files ? 82
Lines ? 4165
Branches ? 0
============================================
Hits ? 4088
Misses ? 77
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://335.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-24 13:13:12 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cond_cat::equivalent matched cond::timeout only against error::timeout, while cond::canceled also matched raw std::errc::operation_canceled. A platform or third-party timed_out code therefore compared equal to cond::canceled's analogue but not to cond::timeout.
Accept std::errc::timed_out for cond::timeout so callers can compare any timeout code against the portable condition, mirroring the canceled branch.