DRYD-2002: Settings for Password Requirements#355
Draft
mikejritter wants to merge 9 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This updates the tenant binding configuration to take in additional settings for password complexity requirements.
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2002
This is a requirement for better HECVAT compatibility.
How should this be tested? Do these changes have associated tests?
tomcat-main/src/main/resources/defaults/settings.xmlneed to be copied into one of the tenantsettings.xmlfiles (e.g. core)services/JaxRsServiceProvider/ant deploy_services_artifactsprotobindings contain the new<tenant:passwordComplexity/>sectionDependencies for merging? Releasing to production?
I did this on top of the JDK 21 update. Otherwise I don't believe there are any dependencies.
The way the settings are read in though is kind of a mess, and makes adding new settings more difficult than it should be. IDK the way settings are handled in general makes the entire process onerous (e.g. needing a recompile to change a value). I'll create a ticket for this to track it.
Has the application documentation been updated for these changes?
No. Docs will need to be added.
Did someone actually run this code to verify it works?
@mikejritter has generated tenant bindings locally