fix: run spinner onCancel on Ctrl+C#581
Conversation
Automation signals@cyphercodes Activity patterns show signs of automation. Classification:
Analyzed 200 public events via @unveil/identity |
🦋 Changeset detectedLatest commit: fa6509f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| return undefined as never; | ||
| }) as typeof process.exit); |
There was a problem hiding this comment.
These type assertions don't give me confidence
|
this isn't quite right. non-zero exits are not necessarily cancellations. i think this needs discussion in an issue before a PR is made. basically, we clack/packages/core/src/utils/index.ts Lines 54 to 58 in 8f1c380 so there's a discussion needed of if we want to continue doing that, or if we want to |
What does this PR do?
Fixes spinner cancellation from Ctrl+C when the keypress is handled by the blocked input path. The spinner now treats the blocked-input exit path as cancellation, passes the configured input stream to
block(), runsonCancel, and setsisCancelled.Closes #573
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure