Make conflicts detectable with errors.Is#165
Open
ian-oneleet wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks, I think it makes sense to expose this information for callers, but I need to think some about the best structure for doing so. I'll let you know if I want to make any adjustments to what you have here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if there are file-level conflicts that prevent applying a patch, the caller only gets back an anonymous
error, so they can't detect whetherApplyfailed due to a conflict or for some other reason.This PR changes the error paths for file-level conflicts to return global sentinel errors, and also wraps content-level conflict errors (
gitdiff.Conflict) in a sentinel error. With these changes, callers can detect conflicts like so:Not too attached to the exact implementation (message wording, error structure, …). Let me know if any of that should change, or feel free to push commits.
Thanks for making this library available!