refactor(ftintitle): cache config options#6732
Merged
snejus merged 1 commit intoJun 13, 2026
Merged
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6732 +/- ##
==========================================
+ Coverage 74.51% 74.53% +0.02%
==========================================
Files 162 162
Lines 20822 20832 +10
Branches 3298 3298
==========================================
+ Hits 15515 15527 +12
+ Misses 4550 4549 -1
+ Partials 757 756 -1
🚀 New features to boost your workflow:
|
e9c89e5 to
b9e0812
Compare
3 tasks
b9e0812 to
9965698
Compare
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
snejus
requested changes
Jun 12, 2026
9965698 to
15259df
Compare
snejus
reviewed
Jun 13, 2026
snejus
approved these changes
Jun 13, 2026
15259df to
adc2056
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-factor for #6726.
Description
Make
ftintitle's config@cached_propertyattributes instead of passing them through the call stack. Modeled after similar recent changes inconvert.Changes
auto,drop,format,keep_in_artist,preserve_album_artist, andcustom_words, keeping the existing cachedbracket_keywordsproperty I forgot I added a while back.commands(),imported(),ft_in_title(), andupdate_metadata()are cleaned up to read these directly.autoduring plugin init; the import stage remains registered andimported()checksautowhen invoked.To Do
Documentation. (If you've added a new command-line flag, for example, find the appropriate page underdocs/to describe it.)Changelog. (Add an entry todocs/changelog.rstto the bottom of one of the lists near the top of the document.)Tests. (Very much encouraged but not strictly required.)