eDit: Enable album-level field editing during interactive import#6727
Open
arsaboo wants to merge 8 commits into
Open
eDit: Enable album-level field editing during interactive import#6727arsaboo wants to merge 8 commits into
arsaboo wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for editing album-level fields during interactive album imports by introducing a YAML header section, along with refactoring the edit flow and expanding documentation/tests.
Changes:
- Show
albumfieldsas a YAML header document during interactive album import editing. - Refactor YAML editing into
_edit_yamland extend importer edit logic to handle header + per-track documents. - Add tests and update docs/changelog to describe the new behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
beetsplug/edit.py |
Implements album-header YAML + refactors edit loop into _edit_yaml and new importer edit application logic. |
test/plugins/test_edit.py |
Adds tests for album-header editing during import. |
docs/plugins/edit.rst |
Documents the new album-header behavior during interactive import editing. |
docs/changelog.rst |
Announces the new interactive import album-header feature. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6727 +/- ##
==========================================
- Coverage 74.52% 74.51% -0.01%
==========================================
Files 162 162
Lines 20818 20916 +98
Branches 3295 3319 +24
==========================================
+ Hits 15515 15586 +71
- Misses 4547 4566 +19
- Partials 756 764 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During interactive import, the
editplugin only exposed item-level fields — thealbumfieldsconfiguration was completely ignored inimporter_edit(). Users who wanted to modify album-level fields such asalbumoryearhad to complete the import, then runbeet edit -a QUERYas a separate step.Solution
Updated
importer_edit()to support editing album-level fields during import. Album fields (configured viaalbumfields) are presented as a YAML header section prepended to the per-track documents. Changes to the header are applied to all items in the album, making album-level edits work in both theeDitandedit Candidateschoices.docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)