Add styling import / export / reset UI#1824
Open
jkemmererupgrade wants to merge 6 commits into
Open
Conversation
Stores icon selections as symbolic lucide:<name> references rather than data URIs, so config files remain human-readable and the picker can highlight the current selection without reverse-engineering the blob. Resolution happens at render time via two paths: - React components (VertexIcon): useResolvedIconUrl hook backed by React Query (staleTime: Infinity) converts lucide:<name> to a base64 SVG data URI on first use and caches the result. - Cytoscape pipeline (renderNode): getLucideSvgString resolves directly from the lucide-react dynamic-import map, skipping any fetch round-trip. Custom-uploaded icons (data: URIs and plain URLs) are unchanged -- they pass through both resolvers untouched. The new IconPicker component (searchable popover, 8-column grid, 50-icon default window) is wired into NodeStyleDialog alongside the existing file upload button so users can choose a Lucide icon or keep uploading their own. Also fixes a pre-existing lint-staged misconfiguration where the root oxlint --fix task matched vitest.config.ts, which oxlint then ignored (matching its own ignorePatterns), causing exit code 1. The root lint-staged config now mirrors the oxlint ignorePatterns by routing *.config.* files to oxfmt only and restricting oxlint to packages/. Pre-flight: pnpm checks, pnpm test (1738/1738), pnpm coverage all pass. This is Slice 1 of the 3-slice split of aws#1589 per @kmcginnes review.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add three buttons to the General Settings page: - Export: downloads current vertex and edge styling as graph-explorer-styling.json - Import: loads a JSON file, applies it as the live styling baseline, and stores it in defaultStylingAtom so per-type Reset on the node style dialog restores to imported values rather than application defaults - Reset All: reverts every vertex and edge to the imported baseline (or application defaults if no file has been imported this session) Introduce defaultStyling.ts with a Zod schema (DefaultStylingSchema), parseDefaultStyling, resolveDefaultStyling (converts lucide:<name> shorthand to iconUrl references established by the Lucide icon picker in PR aws#1777), and userStylingToExportFormat. The file format round-trips cleanly via lucide:<name> refs. Add mergeDefaultsIntoUserStyling to userPreferences.ts so imported baselines fill gaps for unstyled types without overwriting user customisations. Update toJsonFileData with an optional indent param (defaults unchanged) so the exported file is human-readable. Add unit tests for the schema, parse/resolve pipeline, hooks, and reset behaviour. Update docs/features/settings.md and docs/features/graph-view.md accordingly. Slice 2 of the 3-slice split of aws#1589. Stacks on aws#1777 (Lucide icon picker).
…rkers useResolvedIconUrl is no longer used after VertexIcon switched to DynamicIcon per maintainer feedback on aws#1777.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Jun 15, 2026
Collaborator
|
Thanks @jkemmererupgrade. Are you still good with me pushing up any changes needed to your branch rather than following the typical review/feedback/change loop? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Slice 2 of the 3-slice split of #1589 per @kmcginnes's review on that PR. This is the Styling Import / Export / Reset UI. Stacks on slice 1 (#1777) because it relies on the
lucide:storage convention slice 1 introduces.Adds three buttons to Settings → General:
graph-explorer-styling.json, 2-space indent). Icons are written as symbolic references ("iconUrl": "lucide:plane") so the file is human-readable and version-controllable."icon": ""field that gets converted to"iconUrl": "lucide:"on import.The per-type Reset to Default button on
NodeStyleDialognow also restores to the imported baseline (when one exists), via a newdefaultStylingAtomreference copy and a sharedmergeDefaultsIntoUserStylinghelper.The shared
toJsonFileDatautility gets an optionalindentparameter (default: compact, to preserve existing callers' behavior). Slice 2's exporter passesindent: 2.File format notes (slice 2 ↔ #1660)
Slice 2's exported format is intentionally a subset of what
#1660'sstyles:section will look like — same{ vertices, edges }record-of-types shape, samelucide:icon refs. When the unified config lands, a slice-2 export can drop straight into#1660understyles:.Deliberately NOT in this PR
/defaultStylingstatic route inapp.ts— that's slice 3, folded into the unified config (Unified server configuration file #1660) per kmcginnes's direction.AppStatusLoader.tsx— slice 3.example/defaultStyling.jsonor Docker-mount docs — slice 3.Validation
pnpm run check:types— cleanpnpm run check:lint— 0 errors / 0 warnings (oxlint)pnpm run check:format— clean (oxfmt)pnpm test— all passpnpm coverage— all four thresholds metlucide:icon refs.Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.