fix: use execFileSync for git commands in preInitSetup to prevent shell injection#14957
Open
svidgen wants to merge 1 commit into
Open
fix: use execFileSync for git commands in preInitSetup to prevent shell injection#14957svidgen wants to merge 1 commit into
svidgen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
execSyncwithexecFileSync(array form) for the two git commands inpackages/amplify-cli/src/init-steps/preInitSetup.ts:git ls-remote <url>invalidateGithubRepo()git clone <url> .incloneRepo()Motivation
Using the array-form
execFileSyncavoids spawning a shell and passes arguments directly to the executable. This is the recommended Node.jschild_processAPI when constructing commands with variable inputs, as it avoids potential issues with special characters in URLs being interpreted by the shell.Changes
execFileSyncfromchild_processexecSync(\git ls-remote ${repoUrl}`)withexecFileSync('git', ['ls-remote', repoUrl])`execSync(\git clone ${repoUrl} .`)withexecFileSync('git', ['clone', repoUrl, '.'])`Testing