Skip to content

fix(verify): add upper bound of 300 seconds for clockTolerance option #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pranav18M wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(verify): add upper bound of 300 seconds for clockTolerance option #1039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9033454
fix(verify): add upper bound validation for clockTolerance option
Pranav18M Jun 29, 2026
1084daf
fix(verify): add upper bound of 300s for clockTolerance option
Pranav18M Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ module.exports = function (jwtString, secretOrPublicKey, options, callback) {
options = {};
}

//clone this object since we are going to mutate it.
options = Object.assign({}, options);

let done;
Expand All @@ -46,6 +45,12 @@ module.exports = function (jwtString, secretOrPublicKey, options, callback) {
return done(new JsonWebTokenError('clockTimestamp must be a number'));
}

if (options.clockTolerance !== undefined && options.clockTolerance > 300) {
return done(new JsonWebTokenError(
'clockTolerance must not exceed 300 seconds to prevent accidental expiry bypass'
));
}

if (options.nonce !== undefined && (typeof options.nonce !== 'string' || options.nonce.trim() === '')) {
return done(new JsonWebTokenError('nonce must be a non-empty string'));
}
Expand Down Expand Up @@ -260,4 +265,4 @@ module.exports = function (jwtString, secretOrPublicKey, options, callback) {

return done(null, payload);
});
};
};