ci: fail on lint warnings and add upstream canary workflow#175
Merged
Conversation
Adds -Werror so lint warnings — notably uses of deprecated upstream
API — fail compilation; the two current uses of URI helpers deprecated
upstream are suppressed with TODOs to migrate to discovery-resolved
URIs after the next testcontainers-ory-hydra release. -Werror can be
disabled with -PlenientLint=true.
Moves the testcontainers-ory-hydra dependency into a version catalog
(gradle/libs.versions.toml); a settings-level catalog overwrite lets
-PtestcontainersOryHydraVersion select a different published version,
which the canary uses for its latest-release jobs.
Adds a weekly/manually-dispatched canary workflow building this app
against upstream in a {main, latest-release} x {lenient, strict}
matrix: main via a Gradle composite build (catches unreleased breaking
changes), latest-release via the newest published Maven Central
artifact (catches pin drift and validates the artifact users consume).
Lenient red means upstream actually breaks this app; strict red with
lenient green means new deprecations to migrate. Informational only;
does not gate merges.
ardetrick
force-pushed
the
ci/upstream-compat
branch
from
926a329 to
7e25392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds -Werror so lint warnings — notably uses of deprecated upstream API — fail compilation; the two current uses of URI helpers deprecated upstream are suppressed with TODOs to migrate to discovery-resolved URIs after the next testcontainers-ory-hydra release. -Werror can be disabled with -PlenientLint=true.
Moves the testcontainers-ory-hydra dependency into a version catalog (gradle/libs.versions.toml); a settings-level catalog overwrite lets -PtestcontainersOryHydraVersion select a different published version, which the canary uses for its latest-release jobs.
Adds a weekly/manually-dispatched canary workflow building this app against upstream in a {main, latest-release} x {lenient, strict} matrix: main via a Gradle composite build (catches unreleased breaking changes), latest-release via the newest published Maven Central artifact (catches pin drift and validates the artifact users consume). Lenient red means upstream actually breaks this app; strict red with lenient green means new deprecations to migrate. Informational only; does not gate merges.