Skip to content

Show disk usage in image list#1720

Open
amarkdotdev wants to merge 1 commit into
apple:mainfrom
amarkdotdev:codex/image-list-disk-usage
Open

Show disk usage in image list#1720
amarkdotdev wants to merge 1 commit into
apple:mainfrom
amarkdotdev:codex/image-list-disk-usage

Conversation

@amarkdotdev

Copy link
Copy Markdown

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

container image list did not include disk usage in the default table output. This adds a DISK USAGE column using the same per-variant size data already used by verbose image listing, while excluding attestation manifests reported with the unknown/unknown platform.

Fixes #1712

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Validation run locally:

  • swift test --filter ContainerCommandsTests

@jglogan

jglogan commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

@amarkdotdev thanks for the PR! If this addition reports the same value as that of the FULL SIZE column reported with --verbose, perhaps we should label the columns identically for both non-verbose and verbose usage?

If the value is a reasonable approximation of disk usage, I prefer what you have – DISK USAGE – to FULL SIZE.

@amarkdotdev

Copy link
Copy Markdown
Author

Thanks, that makes sense. This value is not exactly the same shape as the verbose FULL SIZE column: verbose output emits one row per platform variant, while the default table has one row per image reference and aggregates the non-attestation variant sizes for that image. Given that, I think DISK USAGE is the clearer label here.

@amarkdotdev amarkdotdev force-pushed the codex/image-list-disk-usage branch from 1152087 to 3104d5a Compare June 15, 2026 15:21
@jglogan jglogan self-requested a review June 15, 2026 16:54
@saehejkang

Copy link
Copy Markdown
Contributor

@jglogan This PR is related (somewhat) to the changes here and is been ready for a final ✅ . Just wanted to bring it to your inbox, in case there is overlap here.

@amarkdotdev amarkdotdev force-pushed the codex/image-list-disk-usage branch from 3104d5a to e97d1a8 Compare June 16, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: container i ls display DISK USAGE

3 participants