Fix flaky python test#3507
Open
GumpacG wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3507 +/- ##
============================================
- Coverage 76.35% 76.23% -0.13%
- Complexity 13424 13934 +510
============================================
Files 1012 1030 +18
Lines 60341 62874 +2533
Branches 7075 7368 +293
============================================
+ Hits 46076 47934 +1858
- Misses 11548 11961 +413
- Partials 2717 2979 +262 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky gremlin-python test: test_client_side_timeout_set_for_aiohttp
The test asserted
str(err) == ""on the caught timeout, assuming a bareasyncio.TimeoutError(empty message). But the driver arms two read-timeout timers at the same value the driver's asyncio.timeout wrapper and aiohttp's sock_read timer and whichever fires first is a race. When aiohttp's wins, the error is aSocketTimeoutError("Timeout on reading data from socket"), so the message assertion fails intermittently (seen on python-3.11 and python-3.12 across runs).Fix: drop the brittle message-equality assertion. The test still catches
TimeoutError(both variants subclass it), still fails if no timeout occurs, and still verifies the client recovers afterward, it just no longer pins a library-internal message string.