feat(frontend): Virtual Environments: Show loading spinner while system packages resolve#5644
feat(frontend): Virtual Environments: Show loading spinner while system packages resolve#5644SarahAsad23 wants to merge 3 commits into
Conversation
|
👋 Thanks for opening this pull request, @SarahAsad23! It looks like the pull request description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed. You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5644 +/- ##
============================================
- Coverage 52.96% 52.50% -0.46%
+ Complexity 2522 2478 -44
============================================
Files 1075 1074 -1
Lines 41743 41584 -159
Branches 4513 4489 -24
============================================
- Hits 22109 21835 -274
- Misses 18329 18458 +129
+ Partials 1305 1291 -14
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Seems like this PR is depends on #5613 so I'll review this PR after it's merged. |
What changes were proposed in this PR?
PR #5613 removed the
system-requirements-lock.txtfile which changes how system packages are loaded. Previously, the package list was available immediately from the lock file. With the new approach, the system package set is generated on demand by creating a temporary environment, installing the requirements, and running pip freeze, which introduces a noticeable delay on the initial load.The PR introduces new UI changes to handle this new loading state and provide feedback to the user while the system packages are being resolved by adding a loading spinner.
Any related issues, documentation, discussions?
Related PR: #5613.
How was this PR tested?
Tested manually.
Was this PR authored or co-authored using generative AI tooling?
Co-authored using: Claude Code