Skip to content

feat(frontend): Virtual Environments: Show loading spinner while system packages resolve#5644

Open
SarahAsad23 wants to merge 3 commits into
apache:mainfrom
SarahAsad23:system-package-ui
Open

feat(frontend): Virtual Environments: Show loading spinner while system packages resolve#5644
SarahAsad23 wants to merge 3 commits into
apache:mainfrom
SarahAsad23:system-package-ui

Conversation

@SarahAsad23

@SarahAsad23 SarahAsad23 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

PR #5613 removed the system-requirements-lock.txt file which changes how system packages are loaded. Previously, the package list was available immediately from the lock file. With the new approach, the system package set is generated on demand by creating a temporary environment, installing the requirements, and running pip freeze, which introduces a noticeable delay on the initial load.

The PR introduces new UI changes to handle this new loading state and provide feedback to the user while the system packages are being resolved by adding a loading spinner.

image image

Any related issues, documentation, discussions?

Related PR: #5613.

How was this PR tested?

Tested manually.

Was this PR authored or co-authored using generative AI tooling?

Co-authored using: Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for opening this pull request, @SarahAsad23!

It looks like the pull request description doesn't quite follow our template yet:

  • The How was this PR tested? section is empty; please fill it in.
  • The Was this PR authored or co-authored using generative AI tooling? section is empty; please fill it in.

Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.

You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow.

@SarahAsad23 SarahAsad23 marked this pull request as draft June 12, 2026 20:11
@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Jun 12, 2026
@SarahAsad23 SarahAsad23 marked this pull request as ready for review June 12, 2026 20:13
@codecov-commenter

codecov-commenter commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.50%. Comparing base (73c76f5) to head (6838873).

Files with missing lines Patch % Lines
...wer-button/computing-unit-selection.component.html 0.00% 14 Missing ⚠️
...power-button/computing-unit-selection.component.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5644      +/-   ##
============================================
- Coverage     52.96%   52.50%   -0.46%     
+ Complexity     2522     2478      -44     
============================================
  Files          1075     1074       -1     
  Lines         41743    41584     -159     
  Branches       4513     4489      -24     
============================================
- Hits          22109    21835     -274     
- Misses        18329    18458     +129     
+ Partials       1305     1291      -14     
Flag Coverage Δ *Carryforward flag
access-control-service 64.61% <ø> (-6.82%) ⬇️ Carriedforward from cd60535
agent-service 33.34% <ø> (-1.02%) ⬇️ Carriedforward from cd60535
amber 53.26% <ø> (-0.51%) ⬇️ Carriedforward from cd60535
computing-unit-managing-service 1.65% <ø> (ø) Carriedforward from cd60535
config-service 55.38% <ø> (-1.34%) ⬇️ Carriedforward from cd60535
file-service 39.34% <ø> (-17.73%) ⬇️ Carriedforward from cd60535
frontend 47.38% <5.55%> (+<0.01%) ⬆️
pyamber 90.70% <ø> (-0.02%) ⬇️ Carriedforward from cd60535
python 90.74% <ø> (ø) Carriedforward from cd60535
workflow-compiling-service 58.69% <ø> (ø) Carriedforward from cd60535

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chenlica chenlica requested a review from kunwp1 June 13, 2026 07:06
@kunwp1

kunwp1 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Seems like this PR is depends on #5613 so I'll review this PR after it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants