[fix][txn] Fix X-Pulsar-txn-uncommitted header semantics and add X-Pulsar-txn-consumable for peek messages#26073
Open
poorbarcode wants to merge 3 commits into
Open
[fix][txn] Fix X-Pulsar-txn-uncommitted header semantics and add X-Pulsar-txn-consumable for peek messages#26073poorbarcode wants to merge 3 commits into
poorbarcode wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
X-Pulsar-txn-uncommittedresponse header returned bypeekNthMessage / peekMessagesREST APIs incorrectly indicates whether this specific entry's transaction is uncommitted. Currently it comparesentry.position > maxReadPosition, which conflates two distinct concerns: the entry's own transaction state and the visibility of the entry (whether earlier uncommitted transactions block it).Concretely, if transaction T1 is uncommitted and transaction T2 is committed, peeking T2's message still returns
X-Pulsar-txn-uncommitted: trueeven though T2 itself is committed — the header is actually reporting that an earlier uncommitted transaction exists, not that this entry's transaction is uncommitted. This makes the header semantically misleading.We need to:
X-Pulsar-txn-uncommittedto reflect this entry's own transaction state.X-Pulsar-txn-consumablethat reflects whether this entry can currently be consumed (i.e. no uncommitted transactions precede it).Modifications
X-Pulsar-txn-uncommittedposition <= maxReadPosition.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes