[core][python] Improve earliest snapshot retry handling#8242
Open
JingsongLi wants to merge 5 commits into
Open
[core][python] Improve earliest snapshot retry handling#8242JingsongLi wants to merge 5 commits into
JingsongLi wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the earliest snapshot is expired concurrently, callers may observe an earliest snapshot id whose snapshot file is already gone. This PR makes Java and Python retry forward through a bounded window before giving up, while preserving empty-table handling for callers that have no available latest snapshot.
Changes
SnapshotManager.retryEarliestSnapshot, reused by bothSnapshotManagerandTimeTravelUtil.SnapshotManagerwith the Java behavior by retrying from the discovered earliest snapshot id instead of stopping at the first missing snapshot.RuntimeException/RuntimeErrorwhen an identified earliest snapshot range cannot be read after retry, instead of silently returningnull/None.Testing
python -m pytest paimon-python/pypaimon/tests/snapshot_manager_test.py paimon-python/pypaimon/tests/time_travel_util_test.pygit diff --check