IGNITE-28857 Split CDC replication test classes to unlock test parallelization#358
Open
anton-vinogradov wants to merge 1 commit into
Open
IGNITE-28857 Split CDC replication test classes to unlock test parallelization#358anton-vinogradov wants to merge 1 commit into
anton-vinogradov wants to merge 1 commit into
Conversation
d311b78 to
3243006
Compare
…elization Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3243006 to
baad915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cdc suite (~41 min, defines the ~46 min RunAllTests wall-clock) is batch-split by the TeamCity Parallel Tests feature, but the split granularity is a test class, and three giant parameterized classes dominate the run:
CdcKafkaReplicationAppsTest(84 tests, ~41 min),CdcKafkaReplicationTest(84, ~39 min),CdcIgniteToIgniteReplicationTest(96, ~25 min).This PR splits each of them into 4 concrete subclasses, each running a single (clientType, atomicity) slice of the parameters matrix:
*AbstractTest(following the existingCdcPostgreSqlReplicationAbstractTestnaming);ParamsSliceRunner(built on public JUnit4 API:Suite+BlockJUnit4ClassRunnerWithParameters) runs a subclass over the slice declared by the@ParamsSliceclass annotation, so the 12 new leaf classes are empty one-liners like:No test logic changes; the executed test set and the test names (including the parameters suffix) are byte-for-byte the same, so per-test TeamCity history is preserved. The slowest class drops to ~10 min, so the Cdc suite wall-clock is expected to drop to ~11 min and RunAllTests to ~15 min.
Verified locally: full
-Pcheckstylebuild and smoke runs of Ignite-to-Ignite, Kafka and Apps slices are green.https://issues.apache.org/jira/browse/IGNITE-28857
🤖 Generated with Claude Code