HBASE-30241 TestMobCloneSnapshotFromClientAfterSplittingRegion is fla…#8414
Open
liuxiaocs7 wants to merge 2 commits into
Open
HBASE-30241 TestMobCloneSnapshotFromClientAfterSplittingRegion is fla…#8414liuxiaocs7 wants to merge 2 commits into
liuxiaocs7 wants to merge 2 commits into
Conversation
apache#8387) Signed-off-by: Duo Zhang <zhangduo@apache.org> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
liuxiaocs7
added
the
backport
There was a problem hiding this comment.
Pull request overview
This PR addresses HBASE-30241 test flakiness around clone-snapshot behavior after region splits by making the “Reference-file” split case deterministic and adding coverage for the complementary “all HFileLink” split case (including a MOB variant).
Changes:
- Make
CloneSnapshotFromClientAfterSplittingRegionTestBase#splitRegiondeterministic by major-compacting before splitting to ensure reference files are created. - Refactor
CloneSnapshotFromClientTestBasesetup to allow subclasses to customize snapshot naming and table/snapshot creation via overridable hooks. - Add a new “with links” split test base plus concrete test classes (regular + MOB) that validate clone survivability when the split produces only whole-file
HFileLinks.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMobCloneSnapshotFromClientAfterSplittingRegionWithLinks.java | Adds MOB variant of the new “all HFileLink” split/clone survivability test (currently has a compile-blocking type/import issue). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestCloneSnapshotFromClientAfterSplittingRegionWithLinks.java | Adds non-MOB concrete test class wiring for the new “all HFileLink” split/clone test base. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientTestBase.java | Refactors setup to call initSnapshotNames and createTableAndSnapshots separately; makes createTableAndSnapshots overridable. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java | Introduces a new base test verifying clone survives source+snapshot deletion when split produces whole-file HFileLinks (no References). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionTestBase.java | Forces reference-file split behavior by major-compacting table regions before choosing the split row. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#8387)